lkml.org 
[lkml]   [2014]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.11 075/131] net: asix: add missing flag to struct driver_info
    Date
    3.11.10.6 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Emil Goode <emilgoode@gmail.com>

    commit d43ff4cd798911736fb39025ec8004284b1b0bc2 upstream.

    The struct driver_info ax88178_info is assigned the function
    asix_rx_fixup_common as it's rx_fixup callback. This means that
    FLAG_MULTI_PACKET must be set as this function is cloning the
    data and calling usbnet_skb_return. Not setting this flag leads
    to usbnet_skb_return beeing called a second time from within
    the rx_process function in the usbnet module.

    Signed-off-by: Emil Goode <emilgoode@gmail.com>
    Reported-by: Bjørn Mork <bjorn@mork.no>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/net/usb/asix_devices.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
    index ad5d1e4..97b5de7 100644
    --- a/drivers/net/usb/asix_devices.c
    +++ b/drivers/net/usb/asix_devices.c
    @@ -915,7 +915,8 @@ static const struct driver_info ax88178_info = {
    .status = asix_status,
    .link_reset = ax88178_link_reset,
    .reset = ax88178_reset,
    - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_LINK_INTR,
    + .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_LINK_INTR |
    + FLAG_MULTI_PACKET,
    .rx_fixup = asix_rx_fixup_common,
    .tx_fixup = asix_tx_fixup,
    };
    --
    1.9.0
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2014-03-08 17:41    [W:2.246 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site