Messages in this thread | | | Date | Wed, 5 Mar 2014 12:16:37 +0000 | From | Wei Liu <> | Subject | Re: [PATCH net-next v6 1/10] xen-netback: Use skb->cb for pending_idx |
| |
On Tue, Mar 04, 2014 at 10:32:12PM +0000, Zoltan Kiss wrote: > Storing the pending_idx at the first byte of the linear buffer never looked > good, skb->cb is a more proper place for this. It also prevents the header to > be directly grant copied there, and we don't have the pending_idx after we > copied the header here, so it's time to change it. >
I think this is a valid change. But I would like you to define a skb_cb_overlay just like the receive path does.
You can rename skb_cb_overlay in current code to skb_cb_overlay_rx and add your skb_cb_overlay_tx.
Wei.
| |