Messages in this thread | | | Date | Wed, 5 Mar 2014 20:34:25 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 2/2] serial: sh-sci: Add missing call to uart_remove_one_port() in failure path |
| |
On Thu, Mar 06, 2014 at 01:19:13PM +0900, Simon Horman wrote: > On Fri, Feb 28, 2014 at 02:21:33PM +0100, Geert Uytterhoeven wrote: > > From: Geert Uytterhoeven <geert+renesas@linux-m68k.org> > > > > If cpufreq_register_notifier() fails, we have to remove the port added by > > sci_probe_single(), which is not done by sci_cleanup_single(). > > > > Else the serial port stays active from the point of view of the serial > > subsystem, and it may crash when userspace getty is started, or when the > > loadable driver module is unloaded. > > > > This was introduced by commit 6dae14216c85eea13db7b12c469475c5d30e5499 > > ("serial: sh-sci: Fix probe error paths"). > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org> > > Acked-by: Simon Horman <horms+renesas@verge.net.au> > > This looks reasonable to me. > > Greg, could you take this one?
Will do, thanks.
| |