Messages in this thread | | | Date | Thu, 6 Mar 2014 12:31:13 +0800 | From | Mark Brown <> | Subject | Re: [PATCH v2] mfd: max8997: use regmap to access registers |
| |
On Wed, Mar 05, 2014 at 10:54:39AM -0800, Dmitry Torokhov wrote: > On Wed, Mar 05, 2014 at 03:58:17PM +0100, Robert Baldyga wrote:
> > -int max8997_write_reg(struct i2c_client *i2c, u8 reg, u8 value) > > +int max8997_write_reg(struct regmap *map, u8 reg, u8 value)
> Why don't you make read/write reg to take struct max8997_dev as argument > instead of regmap? regmap seems to be the current implementation du jur, > but that is core's detail, functions do not need to care.
Indeed, and had this been done originally this refactoring would be much smoother. [unhandled content-type:application/pgp-signature] | |