Messages in this thread | | | Date | Wed, 05 Mar 2014 08:04:44 -0500 | From | Prarit Bhargava <> | Subject | Re: [PATCH] x86, apic, Fix missing replacement for VECTOR_UNDEFINED |
| |
On 03/04/2014 05:37 PM, David Rientjes wrote: > On Tue, 4 Mar 2014, Prarit Bhargava wrote: > >> linux.git commit 9345005f4eed805308193658d12e4e7e9c261e74 added >> a definition for VECTOR_UNDEFINED = -1. There is a missing replacement in >> the io_apic.c file. Found during debugging of another issue. >> >> Cc: Rui Wang <rui.y.wang@intel.com> >> Cc: Michel Lespinasse <walken@google.com> >> Cc: Seiji Aguchi <seiji.aguchi@hds.com> >> Cc: Yang Zhang <yang.z.zhang@Intel.com> >> Cc: Paul Gortmaker <paul.gortmaker@windriver.com> >> Cc: janet.morgan@Intel.com >> Cc: tony.luck@Intel.com >> Cc: ruiv.wang@gmail.com >> Signed-off-by: Prarit Bhargava <prarit@redhat.com> > > Acked-by: David Rientjes <rientjes@google.com> > > I think it would have been better to define VECTOR_UNDEFINED to be (-1) > rather than -1, though, to ensure it can't be used erroneously as an > arithmetic operation.
Good point David, I'll push a separate patch for your suggestion. As always, thanks for acking :)
P.
| |