lkml.org 
[lkml]   [2014]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag
Date
Hi Joe,

On Wednesday 05 March 2014 17:00:37 Joe Perches wrote:
> On Thu, 2014-03-06 at 01:48 +0100, Laurent Pinchart wrote:
> > Would you recommend to drop driver-specific Kconfig options related to
> > debugging and use CONFIG_DYNAMIC_DEBUG instead ?
>
> For development, sure, if there's sufficient memory.
>
> For embedded systems with limited memory, using dynamic_debug isn't always
> possible or effective.
>
> Also, there are sometimes reasons to have debugging messages always enabled
> or emitted.
>
> For those cases, either adding #define DEBUG or using printk(KERN_DEBUG
> would be fine.

My goal here is to offer an easy way for users to enable debugging without
requiring changes to the source code. The driver includes various dev_dbg()
messages, I don't want to ask people reporting problems to turn them into
printk() calls :-) Even adding #define DEBUG at the beginning of the source
files is likely too error prone for users without much programming experience.

--
Regards,

Laurent Pinchart



\
 
 \ /
  Last update: 2014-03-06 02:41    [W:0.070 / U:0.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site