lkml.org 
[lkml]   [2014]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [RFC V1 2/2] rtc: da9063: RTC driver
Date

On: 05 March 2014 15:41 Alessandro Zummo [mailto:a.zummo@towertech.it] wrote

>-----Original Message-----
>From: Alessandro Zummo [mailto:a.zummo@towertech.it]
>Sent: 05 March 2014 15:41
>
>On Wed, 5 Mar 2014 12:25:16 +0000
>"Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com> wrote:
>
>> + if (IS_ERR(rtc->rtc_dev)) {
>> + ret = PTR_ERR(rtc->rtc_dev);
>> + goto err;
>> + }
>
> please,
>
> return PTR_ERR(....)
>

Yes, thanks, I'll make that change

>> +
>> + irq_alarm = platform_get_irq_byname(pdev, "ALARM");
>> + ret = devm_request_threaded_irq(&pdev->dev, irq_alarm, NULL,
>> + da9063_alarm_event,
>> + IRQF_TRIGGER_LOW | IRQF_ONESHOT,
>> + "ALARM", rtc);
>> + if (ret)
>> + dev_err(&pdev->dev, "Failed to request ALARM IRQ %d: %d\n",
>> + irq_alarm, ret);
>> +
>> + da9063_data_to_tm(data, &rtc->alarm_time);
>> + rtc->rtc_sync = false;
>> +err:
>> + return ret;
>> +}
>
> if the interrupt is mandatory you should request it before registering
> the rtc device. if it isn't, please return 0.

I will make that change also and resubmit later.
Thank you for your quick response.

Regards
Steve


\
 
 \ /
  Last update: 2014-03-05 18:01    [W:0.606 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site