Messages in this thread | | | Date | Wed, 5 Mar 2014 11:39:35 +0800 | From | Mark Brown <> | Subject | Re: [alsa-devel] [PATCH 01/10] ASoC: core: Add snd_soc_dai_set_tdm_slot_xlate(). |
| |
On Sat, Mar 01, 2014 at 02:19:44PM +0100, Lars-Peter Clausen wrote:
> I'm not quite sure I fully understand what this patch is trying to > solve. It adds a variant snd_soc_dai_set_tdm_slot() that instead of > taking a rx and tx mask calculates the masks based on the number of > slots? In that case I don't really see how the xlate in the name > relates to that. xlate is something you'd typically expect in a > devicetree context. Maybe one should be called > snd_soc_dai_set_tdm_slot() and the other > snd_soc_dai_set_tdm_slot_and_masks()?
> But another question is do we really need this? I don't see the > problem that is solved by this patchset.
My understanding is that the patch set aims to provide a way of using the TDM features of drivers from DT, providing a standardised format for expressing the TDM setup in the DT. I've not looked at the actual code yet though. [unhandled content-type:application/pgp-signature] | |