Messages in this thread | | | Date | Mon, 03 Mar 2014 23:01:25 -0800 | From | Cody P Schafer <> | Subject | Re: [PATCH v3 03/11] perf: provide a common perf_event_nop_0() for use with .event_idx |
| |
On 03/03/2014 09:19 PM, Michael Ellerman wrote: > On Thu, 2014-27-02 at 21:04:56 UTC, Cody P Schafer wrote: >> Rather an having every pmu that needs a function that just returns 0 for >> .event_idx define their own copy, reuse the one in kernel/events/core.c. >> >> Rename from perf_swevent_event_idx() because we're no longer using it >> for just software events. Naming is based on the perf_pmu_nop_*() >> functions. > > You could just use perf_pmu_nop_int() directly.
No, .event_idx needs something that takes a (struct perf_event *), perf_pmu_nop_int() takes a (struct pmu *).
| |