Messages in this thread | | | Subject | Re: [PATCH V2 1/2] checkpatch: Expand parenthesis alignment test to declarations, functions and assignments | From | Joe Perches <> | Date | Mon, 31 Mar 2014 15:10:38 -0700 |
| |
On Mon, 2014-03-31 at 15:06 -0700, Andrew Morton wrote: > On Mon, 31 Mar 2014 14:58:07 -0700 Joe Perches <joe@perches.com> wrote: > > > Currently the parenthesis alignment test works only on > > misalignments of if statements like > > > > if (foo(bar, > > baz) > > > > Expand the test to find misalignments like: > > > > static inline int foo(int bar, > > int baz) > > > > and > > > > foo(bar, > > baz); > > > > and > > > > foo = bar(baz, > > qux); > > > > Expand the $Inline keyword for __inline and __inline__ too. > > Add $Inline to $Declare so it also matches "static inline <foo>". > > I'm having trouble understanding what this patch actually does. Some > little examples would be nice. > > I typed in this to play with: > > void foo(int a, > int b) > { > } > > but I experienced playus interruptus > > akpm3:/usr/src/25> perl scripts/checkpatch.pl -f t.c > Global symbol "$c90_Keywords" requires explicit package name at scripts/checkpatch.pl line 2162. > Execution of scripts/checkpatch.pl aborted due to compilation errors. > > System is Ubuntu 12.04.4 (ish).
You have to apply it to -next (your mm queue)
| |