Messages in this thread | | | Date | Mon, 31 Mar 2014 19:20:38 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] ASoC: fsl_sai: Fix buggy configurations in trigger() |
| |
On Mon, Mar 31, 2014 at 07:39:22PM +0800, Nicolin Chen wrote: > The current trigger() has two crucial problems: > 1) The DMA request enabling operations (FSL_SAI_CSR_FRDE) for Tx and Rx are > now totally exclusive: It would fail to run simultaneous Tx-Rx cases. > 2) The TERE disabling operation depends on an incorrect condition -- active > reference count that only gets increased in snd_pcm_open() and decreased > in snd_pcm_close(): The TERE would never get cleared.
Can you please check that this against my asoc-v3.15-4 tag - it doesn't seem to apply there? [unhandled content-type:application/pgp-signature] | |