Messages in this thread | | | Date | Mon, 31 Mar 2014 16:42:27 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging/wlan-ng fix small coding style issue |
| |
On Mon, Mar 31, 2014 at 03:13:23PM +0200, Denis Pithon wrote: > Signed-off-by: Denis Pithon <denis.pithon@gmail.com>
Changeglog sucks. It doesn't even exist, actually. What coding style issue did you fix?
> --- > drivers/staging/wlan-ng/prism2usb.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/wlan-ng/prism2usb.c b/drivers/staging/wlan-ng/prism2usb.c > index 4739c14..ccb2c2e 100644 > --- a/drivers/staging/wlan-ng/prism2usb.c > +++ b/drivers/staging/wlan-ng/prism2usb.c > @@ -293,6 +293,7 @@ static int prism2sta_suspend(struct usb_interface *interface, > hfa384x_t *hw = NULL; > wlandevice_t *wlandev; > wlandev = (wlandevice_t *) usb_get_intfdata(interface); > + > if (!wlandev) > return -ENODEV;
The blank line should go be one line earlier.
wlandevice_t *wlandev; [blank] wlandev = (wlandevice_t *) usb_get_intfdata(interface);
> > @@ -315,6 +316,7 @@ static int prism2sta_resume(struct usb_interface *interface) > hfa384x_t *hw = NULL; > wlandevice_t *wlandev; > wlandev = (wlandevice_t *) usb_get_intfdata(interface); > +
Same.
> if (!wlandev) > return -ENODEV;
regards, dan carpenter
| |