lkml.org 
[lkml]   [2014]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pci: changed '...pci_bus* bus' to '...pci_bus *bus'
Hello,

This is my first patch. I'm looking for feedback pertaining to my
submission that way I can submit more patches correctly in the future.
Any constructive feedback is welcome.

I have one question in particular regarding the 'Sign by' section in the
git commit message. Am I suppose to add a 'Sign by' line for myself or
is that for the core kernel team?

Thank you for time and feedback,
Ryan

On 03/28/2014 03:13 PM, Ryan Desfosses wrote:
> change made to resolve following checkpatch message:
> drivers/pci/pci.c:109: ERROR: "foo* bar" should be "foo *bar"
> ---
> drivers/pci/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index fdbc294..a50d542 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -106,7 +106,7 @@ static bool pcie_ari_disabled;
> * Given a PCI bus, returns the highest PCI bus number present in the set
> * including the given PCI bus and its list of child PCI buses.
> */
> -unsigned char pci_bus_max_busnr(struct pci_bus* bus)
> +unsigned char pci_bus_max_busnr(struct pci_bus *bus)
> {
> struct list_head *tmp;
> unsigned char max, n;



\
 
 \ /
  Last update: 2014-03-30 23:41    [W:0.110 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site