lkml.org 
[lkml]   [2014]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] staging/ozwpan: coding style ether_addr_copy
On Sat, Mar 29, 2014 at 06:23:26PM -0700, Joe Perches wrote:
> On Sun, 2014-03-30 at 02:29 +0300, Dan Carpenter wrote:
> > These days in the kernel we treat checkpatch.pl and GCC
> > warnings the same so it sucks when they are something conditional.
>
> Treating checkpatch messages like gcc compilation warnings
> and failures has got to change.
>
> There is _no way_ checkpatch can have no false positives.
>

We could argue back and forth, but for now lets just revert the
ether_addr_copy() check because people ignore the alignement requirement
and it just encourages people to introduce bugs.

regards,
dan carpenter



\
 
 \ /
  Last update: 2014-03-30 13:21    [W:0.043 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site