lkml.org 
[lkml]   [2014]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 00/14] uprobes: Add uprobes support for ARM
On 03/02, David Long wrote:
>
> Oleg,
>
> I've been looking at arch/Kconfig and kernel/trace/Kconfig where they
> deal with uprobes. The relevant items are CONFIG_UPROBES and
> CONFIG_UPROBE_EVENT. It just doesn't look right to me.

Yes, this looks strange. I never understood these dependencies. In fact
I even never tried. And I do not really understand kbuild, unfortunately...

>> --- a/arch/Kconfig
>> +++ b/arch/Kconfig
>> @@ -87,7 +87,8 @@ config KPROBES_ON_FTRACE
>>
>> config UPROBES
>> bool "Transparent user-space probes (EXPERIMENTAL)"
>> - depends on UPROBE_EVENT && PERF_EVENTS
>> + depends on ARCH_SUPPORTS_UPROBES
>> + depends on PERF_EVENTS

And why CONFIG_UPROBES should depend on PERF_EVENTS? uprobes can be
used by (say) systemtap without UPROBE_EVENT/PERF_EVENTS.

But as Russell pointed out the events directory is only built if
CONFIG_PERF_EVENTS=y, so it should depend on it or select...


I dunno. Personally I vote for the patch from Srikar in

http://article.gmane.org/gmane.linux.kernel/1017186

This is what we currently have, currently CONFIG_UPROBES is not
user-selectable anyway.

Oleg.



\
 
 \ /
  Last update: 2014-03-03 22:21    [W:0.322 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site