lkml.org 
[lkml]   [2014]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.
Date
> >  static int ak4535_probe(struct snd_soc_codec *codec)
> > {
> > - struct ak4535_priv *ak4535 = snd_soc_codec_get_drvdata(codec);
> > - int ret;
> > -
> > - codec->control_data = ak4535->regmap;
> > - ret = snd_soc_codec_set_cache_io(codec, 8, 8, SND_SOC_REGMAP);
> > - if (ret < 0) {
> > - dev_err(codec->dev, "Failed to set cache I/O: %d\n", ret);
> > - return ret;
> > - }
> > /* power on device */
> > ak4535_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
>
> Are you sure that the set_bias_level() call doesn't do anything with
> I/O? Can I suggest sending a patch that just does the drivers that only
> do set_cache_io() and nothing else in probe - that would be really quick
> and simple to fix.
>
> > - ret = snd_soc_codec_set_cache_io(codec, 8, 8, SND_SOC_REGMAP);
> > - if (ret < 0) {
> > - dev_err(codec->dev, "Failed to set cache I/O: %d\n", ret);
> > - return ret;
> > - }
> > -
> > /* Default to using ALC auto offset calibration mode. */
> > snd_soc_update_bits(codec, DA7213_ALC_CTRL1,
> > DA7213_ALC_CALIB_MODE_MAN, 0);
>
> This one will fail.

Sorry, I'm not very understand why will this fail ? Before the ASoC probe,
the ASoC core will set the I/O.
:)






\
 
 \ /
  Last update: 2014-03-03 09:01    [W:0.063 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site