Messages in this thread |  | | Date | Mon, 3 Mar 2014 14:08:11 +0000 | From | Matt Fleming <> | Subject | Re: [PATCH 06/22] Add helper functions used by arm/arm64 |
| |
On Fri, 14 Feb, at 11:02:49AM, Roy Franz wrote: > > The get_dram_base() function is only used by arm/arm64, but > there is nothing architecture specific about it, which is why I put it > here to begin with. I don't feel strongly about this either way.
Sorry Roy, I just realised that you probably wanted a response from me about this last point.
OK, leaving get_dram_base() in efi-stub-helper.c is fine.
FYI, "NUL" isn't a typo,
> - options_size++; /* NUL termination */ [...] > + options_size++; /* NULL termination */
http://en.wikipedia.org/wiki/Null_character
-- Matt Fleming, Intel Open Source Technology Center
|  |