[lkml]   [2014]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 06/22] Add helper functions used by arm/arm64
On Fri, 14 Feb, at 11:02:49AM, Roy Franz wrote:
> The get_dram_base() function is only used by arm/arm64, but
> there is nothing architecture specific about it, which is why I put it
> here to begin with. I don't feel strongly about this either way.

Sorry Roy, I just realised that you probably wanted a response from me
about this last point.

OK, leaving get_dram_base() in efi-stub-helper.c is fine.

FYI, "NUL" isn't a typo,

> - options_size++; /* NUL termination */
> + options_size++; /* NULL termination */

Matt Fleming, Intel Open Source Technology Center

 \ /
  Last update: 2014-03-03 15:41    [W:0.108 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site