Messages in this thread Patch in this message | | | From | Insop Song <> | Subject | RE: [PATCH] Remove warning printk | Date | Fri, 28 Mar 2014 08:05:23 +0000 |
| |
Hi Greg,
Will send out a new patch mail with single patch shortly.
I have not yet find a good way to reply mail and add patch yet with my mailing server/client.
That's why I send out a separate email instead of replying to Arnd.
Below is his email and it has his signed-off, that's why I put that in my patch you got.
I took that out from a new patch to make it clear on your end.
Regards,
ISS
Here is Arnd's original email ________________________________________ From: Arnd Bergmann <arnd@arndb.de> Sent: Tuesday, March 25, 2014 8:48 AM To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org; Insop Song Subject: [PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro
We specifically build the kernel with -Werror=date-time to detect such macros, which gives us this error:
gs_fpgaboot/gs_fpgaboot.c:376:44: error: macro "__TIMESTAMP__" might prevent reproducible builds [-Werror=date-time] pr_info("built at %s UTC\n", __TIMESTAMP__);
The obvious fix is to remove the printk output line.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c index 89bc84d..7506900 100644 --- a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c +++ b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c @@ -373,7 +373,6 @@ static int __init gs_fpgaboot_init(void) r = -1;
pr_info("FPGA DOWNLOAD --->\n"); - pr_info("built at %s UTC\n", __TIMESTAMP__);
pr_info("FPGA image file name: %s\n", file);
________________________________________ From: Greg KH <gregkh@linuxfoundation.org> Sent: Thursday, March 27, 2014 11:49 PM To: Insop Song Cc: insop.song@gmail.com; linux-kernel@vger.kernel.org; Arnd Bergmann Subject: Re: [PATCH] Remove warning printk On Thu, Mar 27, 2014 at 08:54:43PM -0700, Insop Song wrote: > Found from build with option -Werror=date-time > > Signed-off-by: Insop Song <insop.song@gainspeed.com> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Did Arnd really sign off on this?
And what is with the "odd" subject, your first email should have been the subject of this one. We don't need a "cover letter" for a one-patch email sequence.
Care to fix this up and resend?
thanks,
greg k-h
| |