lkml.org 
[lkml]   [2014]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC PATCH 00/28] ktap: A lightweight dynamic tracing tool for Linux
From
On Sat, Mar 29, 2014 at 12:08 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Fri, Mar 28, 2014 at 09:47:21AM -0400, Jovi Zhangwei wrote:
>> Hi All,
>>
>> The following set of patches add ktap tracing tool.
>
> Yeah!
>
> Thanks for putting this patch set together, it looks good.
>
> But, why hide the kernel portions of ktap in the tools/ directory? Is
> that ok with everyone else? I don't expect to see kernel code burried
> in that directory, so any kernel API changes that might happen, might
> not get propagated into that location.
>
Reasonable, I will try to put kernel module side into kernel/trace/ktap
directory in next version.

There have some duplicated code with kernel/trace/*.c, then maybe
we can integrate it if ktap location more closer with ftrace.

Thanks for this suggestion.

Jovi


\
 
 \ /
  Last update: 2014-03-29 03:21    [W:0.531 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site