Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH v4 09/11] powerpc/perf: add support for the hv 24x7 interface | Date | Wed, 26 Mar 2014 09:43:02 +0000 |
| |
From: Cody P Schafer > On 03/25/2014 03:43 AM, Anton Blanchard wrote: > > > > Hi Cody, > > > > hv-24x7: could not obtain capabilities, error 0x > fffffffffffffffe, not enabling > > hv-gpci: could not obtain capabilities, error 0x > fffffffffffffffe, not enabling > > > >> + pr_info("could not obtain capabilities, error 0x%80lx, not enabling\n", > > > > That's a lot of padding :) > > > > I think this should also be a pr_debug, considering this is not relevant > > to most ppc64 boxes. > > Yep, s/info/debug/ makes sense. The format should have been "%08lx" not > "%80lx", not sure when I screwed that up.
Using "%#x" is an alternative - unless you really need fixed width.
However in this case "%ld" might be more appropriate! If the value is a -ve errno one, maybe even "errno %d" and negate the value.
David
| |