lkml.org 
[lkml]   [2014]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.8 50/81] ARM64: unwind: Fix PC calculation
    Date
    3.8.13.20 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Olof Johansson <olof@lixom.net>

    commit e306dfd06fcb44d21c80acb8e5a88d55f3d1cf63 upstream.

    The frame PC value in the unwind code used to just take the saved LR
    value and use that. That's incorrect as a stack trace, since it shows
    the return path stack, not the call path stack.

    In particular, it shows faulty information in case the bl is done as
    the very last instruction of one label, since the return point will be
    in the next label. That can easily be seen with tail calls to panic(),
    which is marked __noreturn and thus doesn't have anything useful after it.

    Easiest here is to just correct the unwind code and do a -4, to get the
    actual call site for the backtrace instead of the return site.

    Signed-off-by: Olof Johansson <olof@lixom.net>
    Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    arch/arm64/kernel/stacktrace.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c
    index d25459f..048334b 100644
    --- a/arch/arm64/kernel/stacktrace.c
    +++ b/arch/arm64/kernel/stacktrace.c
    @@ -48,7 +48,11 @@ int unwind_frame(struct stackframe *frame)

    frame->sp = fp + 0x10;
    frame->fp = *(unsigned long *)(fp);
    - frame->pc = *(unsigned long *)(fp + 8);
    + /*
    + * -4 here because we care about the PC at time of bl,
    + * not where the return will go.
    + */
    + frame->pc = *(unsigned long *)(fp + 8) - 4;

    return 0;
    }
    --
    1.8.3.2


    \
     
     \ /
      Last update: 2014-03-25 19:01    [W:3.385 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site