[lkml]   [2014]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] staging/usbip: fix store_attach() sscanf return value check

On 03/25/2014 02:12 AM, Shuah Khan wrote:

> Fix commit - 88fa1ebfa21b5deaaad2dc88ecd9f6af91796cf7

Please also specify that commit's summary line in parens. Also, there's
now an established format for such things:

Fixes: <12-digit SHA ID> ("<summary line>")

You can place such line before your signoff line.

> This commit added return value check for sscanf() that parses the
> input buffer for four input items. However, the return value check
> is incorrect, as it checks for one input item instead of four which
> is what it is expecting in the input buffer. As a result, sscanf()
> will always fail even when the input buffer is correct.

> Signed-off-by: Shuah Khan <>

WBR, Sergei

 \ /
  Last update: 2014-03-25 17:21    [W:0.083 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site