lkml.org 
[lkml]   [2014]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 0/2] mmc: rtsx: add new cmd type handle and modify error handle
From
On 25 March 2014 10:47,  <micky_ching@realsil.com.cn> wrote:
> From: Micky Ching <micky_ching@realsil.com.cn>
>
> Add new command type(R1 without CRC) handle, without this
> patch mmc card initialize will be failed.
>
> Using a more careful handle in request timeout, this would
> improve error recover capability. Debug info is printed
> using non DMA mode, this would help print more accurately
> for DMA command failed. Smatch warning was removed.

Hi Micky,

Seems like this patchset has been around for some time, sorry for the delay.

I don't have any objections to it getting merged, but you need to run
checkpatch of your patches. Patch2 has a warning you should fix.

Kind regards
Ulf Hansson


>
> Micky Ching (2):
> mmc: rtsx: add R1-no-CRC mmc command type handle
> mmc: rtsx: modify error handle and remove smatch warnings
>
> drivers/mmc/host/rtsx_pci_sdmmc.c | 121 ++++++++++++++++++++-----------------
> 1 file changed, 67 insertions(+), 54 deletions(-)
>
> --
> 1.7.9.5


\
 
 \ /
  Last update: 2014-03-25 12:21    [W:3.407 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site