Messages in this thread | | | Date | Mon, 24 Mar 2014 12:58:21 -0700 | From | Jens Axboe <> | Subject | Re: [PATCH] block: Use RCU_INIT_POINTER(x, NULL) in blk-ioc.c |
| |
On 2014-03-22 13:29, Monam Agarwal wrote: > This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL) > > The rcu_assign_pointer() ensures that the initialization of a structure > is carried out before storing a pointer to that structure. > And in the case of the NULL pointer, there is no structure to initialize. > So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)
What's the point of further complicating the API for cases where we don't even really care about performance?
-- Jens Axboe
| |