lkml.org 
[lkml]   [2014]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] netlink: simplify nfnetlink_bind
On Fri, Mar 21, 2014 at 12:44:09PM -0400, Richard Guy Briggs wrote:
> Remove duplicity and simplify code flow by moving the rcu_read_unlock() above
> the condition and let the flow control exit naturally at the end of the
> function.
>
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> ---
> net/netfilter/nfnetlink.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c
> index 046aa13..75619f9 100644
> --- a/net/netfilter/nfnetlink.c
> +++ b/net/netfilter/nfnetlink.c
> @@ -399,12 +399,10 @@ static void nfnetlink_bind(int group)
>
> rcu_read_lock();
> ss = nfnetlink_get_subsys(type);
> + rcu_read_unlock();
> if (!ss) {
> - rcu_read_unlock();
> request_module("nfnetlink-subsys-%d", type);
> - return;
> }
> - rcu_read_unlock();

Applied with minor glitch. Removed the brackets in that if branch.
Thanks


\
 
 \ /
  Last update: 2014-03-24 12:21    [W:0.046 / U:1.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site