| Date | Sun, 23 Mar 2014 17:24:54 -0700 | From | Dmitry Torokhov <> | Subject | Re: [patch 16/16] input: serio: hp_sdc: Use del_timer_sync() in exit path |
| |
On Sun, Mar 23, 2014 at 03:09:33PM -0000, Thomas Gleixner wrote: > Make sure that no callback is running before we teardown the module. >
Applied, thank you Thomas.
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: input <linux-input@vger.kernel.org> > --- > drivers/input/serio/hp_sdc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: tip/drivers/input/serio/hp_sdc.c > =================================================================== > --- tip.orig/drivers/input/serio/hp_sdc.c > +++ tip/drivers/input/serio/hp_sdc.c > @@ -984,7 +984,7 @@ static void hp_sdc_exit(void) > free_irq(hp_sdc.irq, &hp_sdc); > write_unlock_irq(&hp_sdc.lock); > > - del_timer(&hp_sdc.kicker); > + del_timer_sync(&hp_sdc.kicker); > > tasklet_kill(&hp_sdc.task); > > >
-- Dmitry
|