lkml.org 
[lkml]   [2014]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [rcuwalk] e2a728c2785: -29.4% aim7.2000.jobs-per-min, +71% turbostat.Pkg_W
On Sat, Mar 22, 2014 at 07:56:36PM +0800, Fengguang Wu wrote:
> Hi Al,
>
> We noticed the below changes on
>
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git untested-mnt_hash
> commit e2a728c2785d6aab45d1a6d2c61e986d385c30bf ("rcuwalk: recheck mount_lock after mountpoint crossing attempts")

*doh*

Sorry about that - what happens is that __follow_mount_rcu() does that
check every time it's called, not on every negative lookup from
__lookup_mnt(). IOW, it's a massive overkill - most of the time
we don't call __lookup_mnt() at all, due to d_mountpoint() being false,
or get a positive from it.

Fixed and force-pushed; should get much better now...


\
 
 \ /
  Last update: 2014-03-22 15:41    [W:2.133 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site