Messages in this thread | | | From | Alexander Shiyan <> | Subject | Re: [PATCH] mtd: diskonchip: mem resource nam e is not optional | Date | Sat, 22 Mar 2014 12:39:32 +0400 |
| |
Wed, 19 Mar 2014 18:24:37 -0400 от Sasha Levin <sasha.levin@oracle.com>: > Passing a name to request_mem_region() isn't optional and can't just > be NULL. Passing NULL causes a NULL ptr deref later in the boot > process. > > Signed-off-by: Sasha Levin <sasha.levin@oracle.com> > --- > drivers/mtd/nand/diskonchip.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mtd/nand/diskonchip.c b/drivers/mtd/nand/diskonchip.c > index b9b4db6..f68a7bc 100644 > --- a/drivers/mtd/nand/diskonchip.c > +++ b/drivers/mtd/nand/diskonchip.c > @@ -1439,7 +1439,7 @@ static int __init doc_probe(unsigned long physadr) > int reg, len, numchips; > int ret = 0; > > - if (!request_mem_region(physadr, DOC_IOREMAP_LEN, NULL)) > + if (!request_mem_region(physadr, DOC_IOREMAP_LEN, "DiskOnChip")) > return -EBUSY; > virtadr = ioremap(physadr, DOC_IOREMAP_LEN); > if (!virtadr) { > --
Tested-by: Alexander Shiyan <shc_work@mail.ru>
---
| |