lkml.org 
[lkml]   [2014]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ARM: kdump: Avoid overflow when converting pfn to physaddr
    On 2014/3/18 18:48, Russell King - ARM Linux wrote:
    > On Tue, Mar 18, 2014 at 06:20:42PM +0800, Liu Hua wrote:
    >> When we configure CONFIG_LPAE=y, pfn << PAGE_SHIFT will
    >> overflow if pfn >= 0x100000 in copy_oldmem_page.
    >>
    >> So use __pfn_to_phys for converting.
    >
    > Yes. The sad thing is that if you grep the kernel for similar things,
    > it's littered with this problem. I'm not sure whether anyone
    > particularly "owns" the crash_dump.c file - Mika Westerberg and
    > Olaf Hering were the last two to touch it... I guess put this in my
    > patch system please.
    >
    > Thanks.
    >

    Yes, I found this problem in serval places after a quick review. I will
    do a check on this.



    \
     
     \ /
      Last update: 2014-03-22 07:04    [W:5.009 / U:0.332 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site