lkml.org 
[lkml]   [2014]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RESEND][PATCH 1/2] lib/scatterlist: Make ARCH_HAS_SG_CHAIN an actual Kconfig
    On Sat, 22 Mar 2014, James Bottomley wrote:

    > On Sat, 2014-03-22 at 11:13 -0700, Laura Abbott wrote:
    > > Rather than have architectures #define ARCH_HAS_SG_CHAIN in an architecture
    > > specific scatterlist.h, make it a proper Kconfig option and use that
    > > instead. At same time, remove the header files are are now mostly
    > > useless and just include asm-generic/scatterlist.h.
    >
    > Well, the transformation looks fine. Perhaps part of the reason for the
    > lack of response is that there's no compelling reason in the change log
    > above for doing this. The usual reason for eliminating ARCH_HAS is that
    > it's hiding something that would be better expressed a different way
    > (that's actually intuitive to grep) or that it's expressing something
    > that should be configurable. Neither of these reasons apply in this
    > case, because SG_CHAIN definitely is a property of the architecture not
    > the config space and it's not really hiding anything.

    Getting rid of pointless copied code is definitely a good enough
    reason and the patch removes quite some of that.

    Thanks,

    tglx


    \
     
     \ /
      Last update: 2014-03-22 23:21    [W:4.736 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site