Messages in this thread | | | Date | Sat, 22 Mar 2014 16:03:27 -0600 | From | Shuah Khan <> | Subject | Re: [PATCH] media: em28xx-video - change em28xx_scaler_set() to use em28xx_reg_len() |
| |
On 03/22/2014 11:40 AM, Frank Schäfer wrote: > > I'm more concerned about the fact that readers of the code could think > that this is a write with a variable length, while the length is > actually always the same.
Fair enough.
> > em28xx_reg_len() is a somewhat dirty hack for vidioc_[g,s]_register > debugging ioctls only.
I didn't realize that. In that case, it doesn't make sense to propagate the change to non-debug code. This patch can be dropped. I thought em28xx_reg_len() is good example of finding register length for these registers.
> Btw, what happens when you try to compile the code with this patch > applied and CONFIG_VIDEO_ADV_DEBUG disabled ? ;-)
CONFIG_VIDEO_ADV_DEBUG is disabled in my config.
-- Shuah
-- Shuah Khan Senior Linux Kernel Developer - Open Source Group Samsung Research America(Silicon Valley) shuah.kh@samsung.com | (970) 672-0658 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |