Messages in this thread | | | Date | Sat, 22 Mar 2014 13:32:07 -0400 | From | tytso@mit ... | Subject | Re: [RFC 1/1] fs/reiserfs/journal.c: Remove obsolete __GFP_NOFAIL |
| |
On Sat, Mar 22, 2014 at 01:26:06PM -0400, tytso@MIT.EDU wrote: > > Well. Converting an existing retry-for-ever caller to GFP_NOFAIL is > > good. Adding new retry-for-ever code is not good.
Oh, and BTW --- now that checkpatch.pl now flags an warning whenever GFP_NOFAIL is used, because it is deprecated, patches that convert a loop to use GFP_NOFAIL will get flagged with checkpatch, and this will also incentivize people writing new code and who can't find any other way to deal with an allocation failure to simply open code the loop...
- Ted
| |