Messages in this thread Patch in this message | | | Date | Fri, 21 Mar 2014 15:54:03 -0400 | From | Mike Snitzer <> | Subject | [RFC PATCH] UBI: fix rb_tree node comparison in add_map |
| |
The comparisons used in add_vol() shouldn't be identical. Pretty sure the following is correct but it is completely untested.
Signed-off-by: Mike Snitzer <snitzer@redhat.com> --- drivers/mtd/ubi/fastmap.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
NOTE: I stumbled upon this code while implementing some rb_tree code (and looking for some existing rb_tree code as a reference).
diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c index ead8613..60c7a20 100644 --- a/drivers/mtd/ubi/fastmap.c +++ b/drivers/mtd/ubi/fastmap.c @@ -125,9 +125,9 @@ static struct ubi_ainf_volume *add_vol(struct ubi_attach_info *ai, int vol_id, parent = *p; av = rb_entry(parent, struct ubi_ainf_volume, rb); - if (vol_id > av->vol_id) + if (vol_id < av->vol_id) p = &(*p)->rb_left; - else if (vol_id > av->vol_id) + else p = &(*p)->rb_right; }
| |