Messages in this thread | | | Date | Fri, 21 Mar 2014 12:04:29 +0000 | From | Sudeep Holla <> | Subject | Re: [PATCH RFC/RFT v3 6/9] powerpc: move cacheinfo sysfs to generic cacheinfo infrastructure |
| |
Hi Anshuman,
On 21/03/14 03:44, Anshuman Khandual wrote: > On 03/10/2014 04:42 PM, Sudeep Holla wrote: >> Hi Anshuman, >> >> On 07/03/14 06:14, Anshuman Khandual wrote: >>> On 03/07/2014 09:36 AM, Anshuman Khandual wrote: >>>> On 02/19/2014 09:36 PM, Sudeep Holla wrote: >>>>> From: Sudeep Holla <sudeep.holla@arm.com> >>>>> >>>>> This patch removes the redundant sysfs cacheinfo code by making use of >>>>> the newly introduced generic cacheinfo infrastructure.
[...]
>>>> When it is UNIFIED we return index 0, which is correct. But the index >>>> for instruction and data cache seems to be swapped which wrong. This >>>> will fetch invalid properties for any given cache type. >>>> >> >> Ah, that's silly mistake on my side, will fix it. >> >>>> I have done some initial review and testing for this patch's impact on >>>> PowerPC (ppc64 POWER specifically). I am trying to do some code clean-up >>>> and re-arrangements. Will post out soon. Thanks ! >> >> Thanks for taking time for testing and reviewing these patches. > > Now that you got some of the problems to work on and resend the patches, I will > hold on to the clean up patches I had. >
I have done most of the changes but still unable to find why the shared_cpu_map is getting incorrect on PPC. All the other wrong entries are fixed. Any clue on shared_cpu_map ?
Regards, Sudeep
| |