Messages in this thread | | | Date | Thu, 20 Mar 2014 20:34:38 -0400 | From | Peter Hurley <> | Subject | Re: Possible software flow problem in serial_core |
| |
On 03/20/2014 07:34 PM, Bollinger, Seth wrote: > Do you have a driver that would be a good example of this? From looking > at serial_core.c:uart_start(), is seems that start_tx() is only called if > the serial_core ring buffer is not empty. If we don¹t stop the > transmitter, we slew too many characters.
Yeah, you're right; thanks for catching this. (I was busy looking at the ll driver and completely missed the bug in the serial core).
uart_start() should not be conditioning the call to start_tx() on the ring buffer being empty; ll drivers should already be able to handle that because CTS flow control change will start_tx regardless of the ring buffer count.
Will you send a patch?
Regards, Peter Hurley -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |