lkml.org 
[lkml]   [2014]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] KVM: ioapic: reinject pending interrupts on KVM_SET_IRQCHIP
Il 20/03/2014 21:24, Alex Williamson ha scritto:
>> >
>> > +void kvm_ioapic_inject_all(struct kvm_ioapic *ioapic, unsigned long irr)
>> > +{
> nit, kvm_ioapic_state.irr is a u32

Yes, but for_each_set_bit requires unsigned long.

>> > + u32 idx;
>> > +
>> > + rtc_irq_eoi_tracking_reset(ioapic);
>> > + for_each_set_bit(idx, &irr, 32) {
>
> Can we use IOAPIC_NUM_PINS in place of 32?

Yes, indeeed.

> > + printk("ioapic_service for GSI %d\n", idx);
>
> Is this leftover debugging? Maybe give it a loglevel if it's
> intentional. Looks reasonable otherwise. Thanks,

I'll remove it. Thanks for the review!

Paolo


\
 
 \ /
  Last update: 2014-03-21 00:01    [W:0.045 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site