lkml.org 
[lkml]   [2014]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/9] Replace rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x,NULL)
On 20/03/14 15:37, Monam Agarwal wrote:
> This patchset uses following coccinelle script to replace
> rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x,NULL)
>
> @@
> expression E;
> @@
> - rcu_assign_pointer(
> + RCU_INIT_POINTER(
> E, NULL)

I am not very familiar with rcu functionality nor coccinelle, but it
looks too generic. I would think only NULL assignments during
initialization should use RCU_INIT_POINTER(). The first patch in the
series does it in a function called unregister_...(). Is it really ok to
do there?

Gr. AvS



\
 
 \ /
  Last update: 2014-03-20 18:21    [W:0.109 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site