Messages in this thread | | | Date | Thu, 20 Mar 2014 15:58:52 +0100 | From | Arend van Spriel <> | Subject | Re: [PATCH 0/9] Replace rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x,NULL) |
| |
On 20/03/14 15:37, Monam Agarwal wrote: > This patchset uses following coccinelle script to replace > rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x,NULL) > > @@ > expression E; > @@ > - rcu_assign_pointer( > + RCU_INIT_POINTER( > E, NULL)
I am not very familiar with rcu functionality nor coccinelle, but it looks too generic. I would think only NULL assignments during initialization should use RCU_INIT_POINTER(). The first patch in the series does it in a function called unregister_...(). Is it really ok to do there?
Gr. AvS
| |