lkml.org 
[lkml]   [2014]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/4] ata: add new-style AHCI platform driver for DaVinci DA850 AHCI controller
Date
On Thursday, March 20, 2014 01:57:10 PM Bartlomiej Zolnierkiewicz wrote:

> > > +#define DA8XX_SYSCFG1_VIRT(x) (da8xx_syscfg1_base + (x))
> > > +#define DA8XX_PWRDN_REG 0x18
> > > +
> > > +/* SATA PHY Control Register offset from AHCI base */
> > > +#define SATA_P0PHYCR_REG 0x178
> > > +
> > > +#define SATA_PHY_MPY(x) ((x) << 0)
> > > +#define SATA_PHY_LOS(x) ((x) << 6)
> > > +#define SATA_PHY_RXCDR(x) ((x) << 10)
> > > +#define SATA_PHY_RXEQ(x) ((x) << 13)
> > > +#define SATA_PHY_TXSWING(x) ((x) << 19)
> > > +#define SATA_PHY_ENPLL(x) ((x) << 31)
> >
> > These can be replaced with BIT(N)
>
> OK, I'll fix it.

Uh, no, we can't use BIT() here.

BIT(N) does (1UL << (N)) and here we have ((N) << offset).

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics



\
 
 \ /
  Last update: 2014-03-20 17:22    [W:0.043 / U:0.776 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site