lkml.org 
[lkml]   [2014]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: block: free q->flush_rq in blk_init_allocated_queue error paths.
On 03/19/2014 01:22 PM, Mike Snitzer wrote:
> On Wed, Mar 19 2014 at 3:12pm -0400,
> Dave Jones <davej@redhat.com> wrote:
>
>> Commit 7982e90c3a ("block: fix q->flush_rq NULL pointer crash on dm-mpath flush")
>> moved an allocation to blk_init_allocated_queue(), but neglected to free
>> that allocation on the error paths that follow.
>>
>> Signed-off-by: Dave Jones <davej@fedoraproject.org>
>
> Ngh.. thanks Dave!
>
> /me hangs his head in shame...
>
> Acked-by: Mike Snitzer <snitzer@redhat.com>
>
> Jens, really sorry about this oversight. I can take it on the chin and
> pick this up for Linus to take this week from linux-dm.git. Your call.

No worries, I'll shove it off to Linus today. Then I can punch you on
the chin next week.

--
Jens Axboe



\
 
 \ /
  Last update: 2014-03-20 16:21    [W:0.041 / U:3.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site