Messages in this thread | | | Subject | Re: [PATCH 1/5] mtd: st_spi_fsm: Remove useless consts from function arguments | From | Joe Perches <> | Date | Thu, 20 Mar 2014 05:13:50 -0700 |
| |
On Thu, 2014-03-20 at 12:03 +0000, Lee Jones wrote: > > Good catch. That wasn't my intention. > > > Why? > An oversight.
That's still not an explanation.
Why, unless cast away by the code itself, is const removal a good thing?
It does serve as an indication to a reader what the code does with the argument.
About the only reason I can think of arguing in favor of removal is inconsistent application of const within the module.
| |