lkml.org 
[lkml]   [2014]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: Stricter module param and sysfs permission checks
From
On Thu, Mar 20, 2014 at 7:27 AM, Dave Jones <davej@redhat.com> wrote:
> On Thu, Mar 20, 2014 at 01:43:44PM +1030, Rusty Russell wrote:
>
> > drivers/mtd/devices/docg3.c:
> > __ATTR(f##id##_dps0_protection_key, S_IWUGO, NULL, dps0_insert_key), \
> > __ATTR(f##id##_dps1_protection_key, S_IWUGO, NULL, dps1_insert_key), \
> >
> > drivers/scsi/pm8001/pm8001_ctl.c:
> > static DEVICE_ATTR(update_fw, S_IRUGO|S_IWUGO,
> > pm8001_show_update_fw, pm8001_store_update_fw);
>
> Why on earth are these world writable ?

Yup.

I like new and improved checks.
Rusty, add my "& 2" check everywhere!


\
 
 \ /
  Last update: 2014-03-20 11:02    [W:0.100 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site