Messages in this thread | | | Date | Sun, 2 Mar 2014 16:49:33 +0100 | Subject | Re: [PATCH 1/1] scripts/checkpatch.pl: to give more detailed warning message in case printk is used in any patch | From | Levente Kurusa <> |
| |
Hi,
2014-03-02 16:40 GMT+01:00 Joe Perches <joe@perches.com>: > On Sun, 2014-03-02 at 16:20 +0100, Levente Kurusa wrote: >> IMHO, this message is too big. The one we already have is nice and clean. >> I would simply do: s/netdev/[subsystem]/ or something among the lines. > > maybe: > > "Prefer [subsystem eg: netdev]_$level2 then dev_$level2 then pr_$level to printk(KERN_$orig ...\n"
Excellent, that looks the best and combines the best of two worlds.
> > or reference the stackoverflow link >
And what if that disappears? Might as well write this to Documentation/CodingStyle as I have previously mentioned. Yogesh, you want to do this or should I?
-- Regards, Levente Kurusa
| |