lkml.org 
[lkml]   [2014]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v21 12/12] x86: Zero-pad the VVAR page

* Stefani Seibold <stefani@seibold.net> wrote:

> By coincidence, the VVAR page is at the end of an ELF segment. As a
> result, if it ends up being a partial page, the kernel loader will
> leave garbage behind at the end of the vvar page. Zero-pad it to a
> full page to fix this issue.
>
> This has probably been broken since the VVAR page was introduced.
> On QEMU, if you dump the run-time contents of the VVAR page, you can
> find entertaining strings from seabios left behind.
>
> It's remotely possible that this is a security bug -- conceivably
> there's some BIOS out there that leaves something sensitive in the
> few K of memory that is exposed to userspace.
>
> Signed-off-by: Andy Lutomirski <luto@amacapital.net>
> Signed-off-by: Stefani Seibold <stefani@seibold.net>

That's not a valid signoff sequence - if the patch came from Andy then
the patch needs to contain a From: Andy line as well. If Andy acked or
reviewed the patch then please add an Acked-by or Reviewed-by line.

Thanks,

Ingo


\
 
 \ /
  Last update: 2014-03-02 12:21    [W:0.091 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site