Messages in this thread | | | Date | Sun, 02 Mar 2014 17:06:03 +0800 | From | "Zhang, Yanmin" <> | Subject | Re: [PATCH] pstore: skip zero size persistent ram buffer in traverse |
| |
On 2014/2/28 14:38, shuox.liu@intel.com wrote: > From: Liu ShuoX <shuox.liu@intel.com> > > In ramoops_pstore_read, a valid prz pointer with zero size buffer will > break traverse of all persistent ram buffers. The latter buffer might > be lost.
Andrew,
Would you like to merge it to your testing tree? pstore is a very important feature for debugging hard issues on Android mobiles.
Yanmin
> > Signed-off-by: Liu ShuoX <shuox.liu@intel.com> > --- > fs/pstore/ram.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c > index a5d0cab..929ea55 100644 > --- a/fs/pstore/ram.c > +++ b/fs/pstore/ram.c > @@ -119,12 +119,12 @@ ramoops_get_next_prz(struct persistent_ram_zone *przs[], uint *c, uint max, > > prz = przs[i]; > > - if (update) { > - /* Update old/shadowed buffer. */ > + /* Update old/shadowed buffer. */ > + if (update) > persistent_ram_save_old(prz); > - if (!persistent_ram_old_size(prz)) > - return NULL; > - } > + > + if (!persistent_ram_old_size(prz)) > + return NULL; > > *typep = type; > *id = i;
| |