Messages in this thread | | | Date | Wed, 19 Mar 2014 13:44:48 +0530 | Subject | Re: [PATCH 2/4] regulator: max8660: Silence checkpatch warnings | From | Sachin Kamat <> |
| |
On 18 March 2014 18:09, Mark Brown <broonie@kernel.org> wrote: > On Tue, Mar 18, 2014 at 03:53:02PM +0530, Sachin Kamat wrote: >> Silences the following type of error/warnings: >> ERROR: that open brace { should be on the previous line >> WARNING: Missing a blank line after declarations > > Applied, but... > >> - static const u8 max8660_addresses[MAX8660_N_REGS] = >> - { 0x10, 0x12, 0x20, 0x23, 0x24, 0x29, 0x2a, 0x32, 0x33, 0x39, 0x80 }; >> + static const u8 max8660_addresses[MAX8660_N_REGS] = { >> + 0x10, 0x12, 0x20, 0x23, 0x24, 0x29, 0x2a, 0x32, 0x33, 0x39, 0x80 }; > > Think about what you're doing here - you want the }; on a new line too.
Sorry about it. I was kind of in two minds about shifting it. I will send a followup for completeness.
-- With warm regards, Sachin
| |