Messages in this thread | | | Date | Wed, 19 Mar 2014 21:47:42 +0100 | From | Thomas Graf <> | Subject | Re: [PATCH] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors |
| |
On 03/19/2014 09:38 PM, Zoltan Kiss wrote: > skb_zerocopy can copy elements of the frags array between skbs, but it doesn't > orphan them. Also, it doesn't handle errors, so this patch takes care of that > as well. > > Signed-off-by: Zoltan Kiss <zoltan.kiss@citrix.com> > ---
> + if (unlikely(skb_orphan_frags(to, GFP_ATOMIC))) { > + skb_tx_error(to); > + return -ENOMEM; > }
I think you should move this down to right before we iterate over the frags.
Looks good otherwise.
| |