lkml.org 
[lkml]   [2014]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 1/5] Documentation: dt: Add Kona PWM binding
From
On Tue, Mar 18, 2014 at 2:18 PM, Thierry Reding
<thierry.reding@gmail.com> wrote:
> On Wed, Mar 12, 2014 at 01:15:42PM -0700, Tim Kryger wrote:

>> @@ -0,0 +1,24 @@
>> +Broadcom Kona PWM controller device tree bindings
>> +
>> +This controller has 6 channels.
>> +
>> +Required Properties :
>> +- compatible: should be "brcm,kona-pwm"
>
> This is somewhat inconsistent because the example below clearly doesn't
> set the compatible property to "brcm,kona-pwm". Perhaps better wording
> would be:
>
> - compatible: should contain "brcm,kona-pwm"

Agreed, what you wrote is more accurate. I will update it.

>> +- reg: physical base address and length of the controller's registers
>> +- clocks: phandle + clock specifier pair for the external clock
>> +- #pwm-cells: should be 3. The first cell specifies the per-chip index
>> + of the PWM to use, the second cell is the period in nanoseconds, and
>> + the third cell is the flags.
>
> Please use the canonical description for this:
>
> - #pwm-cells: Should be 3. See pwm.txt in this directory for a
> description of the cells format.
>
>> +Refer to pwm/pwm.txt for generic pwm controller node properties.
>
> With the above, this line should go away. But still: "pwm controller" ->
> "PWM controller".

Okay. I will use the text you provided and drop the other line.

Sorry for missing the capitalization. I thought I had fixed them all.

Thanks,
Tim


\
 
 \ /
  Last update: 2014-03-19 02:01    [W:0.151 / U:1.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site