Messages in this thread | | | Date | Tue, 18 Mar 2014 14:25:31 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 1/1] MINIX: specific inode data access standardization |
| |
On Tue, 18 Mar 2014 18:52:21 +0100 Fabian Frederick <fabf@skynet.be> wrote:
> minix_i uppercase conversion (like majority of other filesystems). > > ... > > @@ -255,7 +255,7 @@ struct inode *minix_new_inode(const struct inode *dir, umode_t mode, int *error) > inode->i_ino = j; > inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC; > inode->i_blocks = 0; > - memset(&minix_i(inode)->u, 0, sizeof(minix_i(inode)->u)); > + memset(&MINIX_I(inode)->u, 0, sizeof(MINIX_I(inode)->u)); > insert_inode_hash(inode); > mark_inode_dirty(inode);
minix is correct and the other filesystems are wrong.
minix_i() is a regular C function. There is no earthly reason why it should be all-caps.
| |