Messages in this thread | | | Date | Tue, 18 Mar 2014 13:06:44 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] staging: slicoss: Fix prefer ether_addr_copy over memcpy |
| |
On Mon, Mar 17, 2014 at 09:17:35PM -0600, Joel Pelaez Jorge wrote: > This patch fixes the following checkpatch.pl issues caused by the new > function: ether_addr_copy > > Signed-off-by: Joel Pelaez Jorge <joelpelaez@gmail.com> > --- > diff --git a/drivers/staging/slicoss/slicoss.c > b/drivers/staging/slicoss/slicoss.c > index 12aafe3..4ff39aa 100644 > --- a/drivers/staging/slicoss/slicoss.c > +++ b/drivers/staging/slicoss/slicoss.c > @@ -2313,7 +2313,7 @@ static int slic_mcast_add_list(struct adapter > *adapter, char *address) > if (mcaddr == NULL) > return 1; > > - memcpy(mcaddr->address, address, ETH_ALEN); > + ether_addr_copy(mcaddr->address, address); > > mcaddr->next = adapter->mcastaddrs; > adapter->mcastaddrs = mcaddr;
The patch is line-wrapped, and tabs converted to spaces, making it impossible to apply the patch.
Please fix your email client and try again.
greg k-h
| |