lkml.org 
[lkml]   [2014]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/8] regulator: arizona-ldo1: Add processing of init_data from device tree
On Tue, Mar 18, 2014 at 11:15:42AM +0000, Mark Brown wrote:
> On Tue, Mar 18, 2014 at 10:49:13AM +0000, Charles Keepax wrote:
>
> > + - wlf,ldo1 : Initial data for the LDO1 regulator, as covered in
> > + Documentation/devicetree/bindings/regulator/regulator.txt
>
> We don't normally prefix the names of the regulator data with a vendor.
>
> > + np_init = of_get_child_by_name(arizona->dev->of_node, "wlf,ldo1");
>
> You're missing an of_node_put() for this and if you're going to use
> hungarian notation please use a convention other people use. Calling
> things _node seems more common.

The DCVDD one needs an of_node_put but I am not sure this one
does. As it will be copied into the regulator device of_node by
the regulator core so wont of_node_put be called when the device
is destroyed? Admittedly I haven't checked that but seems
sensible that the device structure would put its of_node when it
closes down.

Thanks,
Charles



\
 
 \ /
  Last update: 2014-03-18 18:01    [W:1.055 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site